Site editor: Fix navigation screen actions positioning of children #56233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
andrewserong
requested review from
apeatling,
ciampo,
ramonjd,
t-hamano and
tellthemachines
Contributor
|
Thanks for the PR, @andrewserong! However, @ciampo has submitted #56218 which takes exactly the same approach 😅 |
|
Size Change: +4 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Contributor
Author
Contributor
|
Great minds 💭 Thank you anyway, I appreciate the thoughtfulness ! |
johnbillion
deleted the
fix/navigation-screen-actions-positioning-of-children
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix an issue where the dropdown in the navigation screen actions was displaying too low, as raised in #56005 (comment) by @t-hamano.
Why?
Due to the change in #56136, the dropdown used in the navigation screen displays too low (seems to be caused by a
vertical-align: toprule and that the dropdown toggle isinline-blockwithin a wrapper that is set toblock). The fix in this PR is to set the wrapper to explicitly beflex.How?
Set the wrapper to be
display: flex. I went with this over switching to anHStackbecause we don't want any of the other stuff that comes withHStackby default (gaps between elements, 100% width, etc), but just want to ensure that children are arranged horizontally next to each other.Testing Instructions
trunkgo to to a Navigation menu screen within the site editor browse modeScreenshots or screencast