Skip to content

Update to Node.js 20.x #56331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
desrosj merged 15 commits into from
Dec 20, 2023
Merged

Update to Node.js 20.x #56331

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
442a9fc
Update to Node.js 18.x, but also test 20.x.
desrosj Nov 20, 2023
c949b0b
Remove upper limit.
desrosj Nov 20, 2023
87ee195
update node v18 usage and active LTS alignment in docs
flootr Nov 30, 2023
4721ba5
Update to Node.js 20.x.
desrosj Dec 5, 2023
6a34ee7
Also update the pull request automation workflow.
desrosj Dec 5, 2023
607098b
Updating lock file.
desrosj Dec 6, 2023
2be5ec8
Check for the latest version of Node.
desrosj Dec 7, 2023
33a2034
Merge branch 'trunk' into update/node-to-18-x
desrosj Dec 19, 2023
da39ccf
Simplifying some matrices.
desrosj Dec 19, 2023
5caa347
Add `check-latest` to prevent failures on outdated images.
desrosj Dec 19, 2023
29ec6e4
Try testing Node.js 21.x.
desrosj Dec 19, 2023
d8b83e8
Correct `continue-on-error` syntax.
desrosj Dec 19, 2023
9b7657f
Job name improvements.
desrosj Dec 19, 2023
5d485aa
Remove allowed failures.
desrosj Dec 20, 2023
2bfa462
Merge remote-tracking branch 'origin/trunk' into update/node-to-18-x
desrosj Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Try testing Node.js 21.x.
  • Loading branch information
@desrosj
desrosj committed Dec 19, 2023
commit 29ec6e4e3563e57d1991d06b6e59ca7ee14a913e
8 changes: 6 additions & 2 deletions .github/workflows/create-block.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,15 @@ concurrency:

jobs:
checks:
name: Checks on ${{ matrix.os }}
name: Checks with Node.js ${{ matrix.node }} on ${{ matrix.os }}
runs-on: ${{ matrix.os }}
if: ${{ github.repository == 'WordPress/gutenberg' || github.event_name == 'pull_request' }}
continue-on-error: ${{ matrix.node == '20' && 'false' || 'true' }}
strategy:
fail-fast: false
matrix:
os: [ 'macos-latest', 'ubuntu-latest', 'windows-latest' ]
node: ['20', '21']
os: ['macos-latest', 'ubuntu-latest', 'windows-latest']

steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
Expand All @@ -29,6 +31,8 @@ jobs:

- name: Setup Node.js and install dependencies
uses: ./.github/setup-node
with:
node-version: ${{ matrix.node }}

- name: Create block
shell: bash
Expand Down
11 changes: 9 additions & 2 deletions .github/workflows/unit-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,14 @@ concurrency:

jobs:
unit-js:
name: JavaScript
name: JavaScript (Node.js ${{ matrix.node }}
runs-on: ubuntu-latest
if: ${{ github.repository == 'WordPress/gutenberg' || github.event_name == 'pull_request' }}
continue-on-error: ${{ matrix.node == '20' && 'false' || 'true' }}
strategy:
fail-fast: false
matrix:
node: ['20', '21']

steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
Expand All @@ -32,8 +37,10 @@ jobs:

- name: Setup Node.js and install dependencies
uses: ./.github/setup-node
with:
node-version: ${{ matrix.node }}

- name: Npm build
- name: npm build
# It's not necessary to run the full build, since Jest can interpret
# source files with `babel-jest`. Some packages have their own custom
# build tasks, however. These must be run.
Expand Down