Skip to content

Backmerge block renaming fixes/refactors from 6.4 branch into Gutenberg trunk #56386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
getdave merged 10 commits into from
Nov 24, 2023
Merged

Backmerge block renaming fixes/refactors from 6.4 branch into Gutenberg trunk #56386

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f619b7e
Apply refactor from 6.4 branch
getdave Nov 21, 2023
04ce9fa
Apply fix to lock down rename
getdave Nov 21, 2023
95c006a
Update support hook to check correct support value
getdave Nov 21, 2023
79cca56
Rename hook to match feature
getdave Nov 21, 2023
209841f
Correct test name
getdave Nov 21, 2023
233dd2f
Assert against a Block that doesn’t support the feature
getdave Nov 21, 2023
f3d32b8
Ensure presence of options menu before Rename presence assertion
getdave Nov 22, 2023
79ba2cc
Avoid redundant creation of blocks and use Group directly
getdave Nov 22, 2023
77f7a8a
Add additional test coverage for options menu on unselected blocks
getdave Nov 22, 2023
d6f968f
Update hook to check for correct support
getdave Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update hook to check for correct support
  • Loading branch information
@getdave
getdave committed Nov 22, 2023
commit d6f968f44769180f5c57e2d590f2cb2a6f0a40cf
8 changes: 1 addition & 7 deletions packages/block-editor/src/components/block-rename/use-block-rename.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,7 @@
import { getBlockSupport } from '@wordpress/blocks';

export default function useBlockRename( name ) {
const metaDataSupport = getBlockSupport( name, 'renaming', true );

const supportsBlockNaming = !! (
true === metaDataSupport || metaDataSupport?.name
);

return {
canRename: supportsBlockNaming,
canRename: getBlockSupport( name, 'renaming', true ),
};
}