Skip to content

Template Replace Flow: Avoid column break within the preview box #56505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
t-hamano wants to merge 1 commit into from
Closed

Template Replace Flow: Avoid column break within the preview box #56505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/edit-site/src/components/sidebar-edit-mode/template-panel/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,8 @@ h3.edit-site-template-card__template-areas-title {
@include break-wide() {
column-count: 4;
}

.block-editor-block-patterns-list__list-item {
break-inside: avoid-column;
Copy link
Contributor

@ntsekouras ntsekouras Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the same css rule in swap template modal and while it handles the current use case that it fixes, it does have the problem @Mamaduka describes. I tried a few things but didn't figure out a proper solution. Maybe we can achieve the same result with a different css rule? 🤔 --cc @jameskoster @jasmussen

}
}