Skip to content

Components: Move kebabCase() function from block-editor package and mark it as private API #56758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 15 commits into from
Dec 14, 2023
Merged

Components: Move kebabCase() function from block-editor package and mark it as private API #56758

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ce55611
Components: Move kebabCase() function from block-editor package and m…
t-hamano Dec 4, 2023
dae26b9
Update changelog
t-hamano Dec 4, 2023
11fe4d1
Fix native app test
t-hamano Dec 4, 2023
b96c143
Try to fix native app test
t-hamano Dec 4, 2023
ec98c52
Try to fix mobile app test
t-hamano Dec 4, 2023
faa563b
Try importing kebabCase directly from components
tyxla Dec 5, 2023
9e512d6
Fix another import
tyxla Dec 5, 2023
b6ec1ff
Move changelog entry to Internal section
t-hamano Dec 9, 2023
5625a86
Change the argument type of kebabCase function to unknown
t-hamano Dec 9, 2023
2565e92
Merge branch 'trunk' into components/move-kebabcase
t-hamano Dec 9, 2023
c48080d
Fix lint error
t-hamano Dec 9, 2023
8db901f
Merge duplicate Internal sections
t-hamano Dec 12, 2023
5c77153
Merge branch 'trunk' into components/move-kebabcase
t-hamano Dec 12, 2023
569e9a9
Merge branch 'trunk' into components/move-kebabcase
t-hamano Dec 13, 2023
102e985
Remove type info in the JSDoc comment
t-hamano Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix native app test
  • Loading branch information
@t-hamano
t-hamano committed Dec 4, 2023
commit 11fe4d1cf93060164af27035e2ef719c23fe3ec5
10 changes: 10 additions & 0 deletions packages/components/src/lock-unlock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
/**
* WordPress dependencies
*/
import { __dangerousOptInToUnstableAPIsOnlyForCoreModules } from '@wordpress/private-apis';

export const { lock, unlock } =
__dangerousOptInToUnstableAPIsOnlyForCoreModules(
'I know using unstable features means my theme or plugin will inevitably break in the next version of WordPress.',
'@wordpress/components'
);
13 changes: 13 additions & 0 deletions packages/components/src/private-apis.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/**
* Internal dependencies
*/
import { kebabCase } from './utils/strings';
import { lock } from './lock-unlock';

/**
* Private @wordpress/block-editor APIs.
*/
export const privateApis = {};
lock( privateApis, {
kebabCase,
} );
7 changes: 1 addition & 6 deletions packages/components/src/private-apis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,7 @@ import { ComponentsContext } from './context/context-system-provider';
import Theme from './theme';
import Tabs from './tabs';
import { kebabCase } from './utils/strings';

export const { lock, unlock } =
__dangerousOptInToUnstableAPIsOnlyForCoreModules(
'I know using unstable features means my theme or plugin will inevitably break in the next version of WordPress.',
'@wordpress/components'
);
import { lock } from './lock-unlock';

export const privateApis = {};
lock( privateApis, {
Expand Down