Skip to content

Site and Post Editor: Unify the DocumentBar component #56778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 8 commits into from
Dec 6, 2023
Merged

Site and Post Editor: Unify the DocumentBar component #56778

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
52fffad
Site and Post Editor: Unify the DocumentBar component
youknowriad Dec 5, 2023
d65db30
Make the document bar compact
youknowriad Dec 5, 2023
593b841
Fix e2e tests
youknowriad Dec 5, 2023
4f69987
Fix template/template-part titles and icons
youknowriad Dec 5, 2023
f7653d6
Fix e2e tests
youknowriad Dec 6, 2023
4257daf
Fix typo
youknowriad Dec 6, 2023
a9b300f
Remove useless useMemo
youknowriad Dec 6, 2023
d1eb313
Restore global synced color
youknowriad Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Restore global synced color
  • Loading branch information
@youknowriad
youknowriad committed Dec 6, 2023
commit d1eb3131aacae984040f5708034e3e7a634bd727
7 changes: 7 additions & 0 deletions packages/editor/src/components/document-bar/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,12 @@ function BaseDocumentActions( { postType, postId, onBack } ) {
const isTemplate = [ 'wp_template', 'wp_template_part' ].includes(
postType
);
const isGlobalEntity = [
'wp_template',
'wp_navigation',
'wp_template_part',
'wp_block',
].includes( postType );

useEffect( () => {
if ( ! isMounting.current ) {
Expand All @@ -124,6 +130,7 @@ function BaseDocumentActions( { postType, postId, onBack } ) {
className={ classnames( 'editor-document-bar', {
'has-back-button': !! onBack,
'is-animated': isAnimated,
'is-global': isGlobalEntity,
} ) }
>
{ onBack && (
Expand Down
4 changes: 4 additions & 0 deletions packages/editor/src/components/document-bar/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@
color: var(--wp-block-synced-color);
}

.editor-document-bar.is-global & {
color: var(--wp-block-synced-color);
}

.block-editor-block-icon {
min-width: $grid-unit-30;
flex-shrink: 0;
Expand Down