Editor: Cleanup default editor mode handling #56819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
requested review from
ntsekouras and
ockham
and removed request for
a team
|
Size Change: -10 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 20aeed2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7115004931
|
ellatrix
reviewed
Dec 6, 2023
| // Sets the right rendering mode when loading the editor. | ||
| useEffect( () => { | ||
| setRenderingMode( settings.defaultRenderingMode ?? 'post-only' ); | ||
| }, [ settings.defaultRenderingMode, setRenderingMode ] ); |
Member
There was a problem hiding this comment.
Why does setRenderingMode exist? Why not reuse settings?
Contributor
Author
There was a problem hiding this comment.
because it can be changed within the editor itself. the "settings" are something an external user of the EditorProvider component provides.
ellatrix
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #56778
What?
Just a small cleanup function, now that we have a setting that indicates the "default editor mode". I believe the "EditorProvider" should set that mode when the setting changes. This allows us to remove some effects from the initialization code of both post and site editors.
Testing instructions
Just ensure that opening the edit templates, template parts, pages... in the site editor lands you in the right mode (you can only edit the right things)