Add typing test when top toolbar is mounted #56908
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally, this metric should be similar to the performance of the typing metric of when the toolbar is not mounted (typing perf results).
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 98e57e0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7143932144
|
draganescu
approved these changes
Dec 8, 2023
Contributor
draganescu
left a comment
draganescu
left a comment
There was a problem hiding this comment.
I think this is a good addition as long as typing requires us to unmount the toolbar b/c of performance.
WunderBart
requested changes
Dec 12, 2023
Comment on lines
+100
to
+101
| minWithTopToolbarType: minimum( results.typeWithTopToolbar ), | ||
| maxWithTopToolbarType: maximum( results.typeWithTopToolbar ), |
Member
There was a problem hiding this comment.
Let's skip those. We didn't include them with the recently added typeWithToolbar as well.
|
|
||
| test( 'Setup the test post', async ( { admin, perfUtils, editor } ) => { | ||
| await admin.createNewPost(); | ||
| await editor.setIsFixedToolbar( true ); |
Member
There was a problem hiding this comment.
This is a global, persistent setting so it needs to be reverted after the test or it will affect other metrics. See this PR as an example on how to handle it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, this metric should be similar to the performance of the typing metric of when the toolbar is not mounted (typing perf results). This gives us a decent proxy for how much the
<BlockToolbar />is doing on each keypress. At the moment, there seems to be a lot of unnecessary rendering happening on each keypress, especially with<BlockSwitcher />.What?
Adds a performance test for typing with the top toolbar.
Why?
To measure performance of typing without the toolbar mounted (default typing metric) vs mounted (top toolbar).
How?
Duplicates the typing test, but sets the Top Toolbar option.
Testing Instructions
Performance Tests for this PR should pass. Check for
typeWithTopToolbar.