Skip to content

CustomSelectControl: Add adapter for legacy to new version #57000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brookewp wants to merge 17 commits into from
Closed

CustomSelectControl: Add adapter for legacy to new version #57000

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e459795
Move components to own files
brookewp Dec 12, 2023
4849671
Add legacy adapter
brookewp Dec 12, 2023
ad420cb
Add legacy tests
brookewp Dec 12, 2023
8ff217f
Update component name and role in tests
brookewp Dec 12, 2023
cf92134
Remove tests that aren’t needed
brookewp Dec 12, 2023
aecb685
Add hint to adapter
brookewp Dec 13, 2023
205668c
Remove ts ignore
brookewp Dec 13, 2023
7e17628
Add prop to hide label visually while keeping it available for screen…
brookewp Dec 15, 2023
6a8b385
Add deprecated legacy props describedBy and __nextUnconstrainedWidth
brookewp Dec 15, 2023
123161d
Update test for deprecating legacy component
brookewp Dec 16, 2023
ebca4a4
Add checks against new version of component with CustomSelectItem
brookewp Dec 16, 2023
4ecfc46
Add section for legacy tests
brookewp Dec 16, 2023
d8d53a4
Add tests for multi-select
brookewp Dec 16, 2023
be23910
Update hint styles and adapt sizes
brookewp Jan 5, 2024
58e6acb
Move tests for new features to another PR
brookewp Jan 8, 2024
0b2db39
Fix label type
brookewp Jan 11, 2024
ee89e01
Fix types
brookewp Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix label type
  • Loading branch information
@brookewp
brookewp committed Jan 11, 2024
commit 0b2db3959d8b0beac740f10463398a6c9aa32786
7 changes: 1 addition & 6 deletions packages/components/src/custom-select-control-v2/legacy-adapter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,5 @@ import type { LegacyCustomSelectProps } from './types';
import { useDeprecatedProps } from './use-deprecated-props';

export function LegacyAdapter( props: LegacyCustomSelectProps ) {
return (
<CustomSelect
{ ...useDeprecatedProps( props ) }
hideLabelFromVision={ props.hideLabelFromVision }
/>
);
return <CustomSelect { ...useDeprecatedProps( props ) } />;
}
2 changes: 1 addition & 1 deletion packages/components/src/custom-select-control-v2/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export type LegacyCustomSelectProps = {
/**
* Label for the control.
*/
label?: string;
label: string;
/**
* A function that receives the new value of the input.
*/
Expand Down
6 changes: 2 additions & 4 deletions packages/components/src/custom-select-control-v2/use-deprecated-props.tsx
View file
Open in desktop
Copy link
Contributor Author

@brookewp brookewp Dec 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to mark the props as to be deprecated, if we decide we want to go with this option

Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,8 @@ export function useDeprecatedProps(
return {
...legacyProps,
children: transformOptionsToChildren( props ),
// temp ignore
//@ts-ignore
defaultValue: props?.value?.name ?? undefined,
label: props.label ?? '',
label: props.label,
hideLabelFromVision: props.hideLabelFromVision,
onChange: legacyChangeHandler,
size: adaptSizes( props ),
};
Expand Down