-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Social Icons: add Doctolib service #57167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @cvlc12! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
Hi ! Are PRs like this one likely to be considered at all ? Have a good day |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @cvlc12. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This introduces a new Social Link icon, for the Doctolib service. Doctolib offers profile pages that health professionals can use to list their presence on the web. It can be useful to link to that from your blog.
|
Hi, just rebased as this is 4 months old now. @ajitbohra is there anything else needed for this to be considered ? |
|
Closing in favor of #70261. The extensibility feature will ship in WP 6.9 and is already available in Gutenberg 21.1. Here's an example plugin - https://github.com/wptrainingteam/devblog-custom-social-icons. |
What?
This introduces a new Social Link icon, for the Doctolib service.
Why?
Doctolib offers profile pages that health professionals can use to list their presence on the web.
How?
This adds the new icon and service, as well as tests.
Testing Instructions
Testing Instructions for Keyboard
No change
Note:I used #56544 as a template and changed filenames and svg icons only, so everything should be functionally equivalent
