Fix/tooltip hide on blur #57204
Closed
Fix/tooltip hide on blur #57204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 19, 2023
ciampo
added
[Package] Components
ciampo
commented
Dec 19, 2023
Comment on lines
+70
to
+71
| showTimeout: delay, | ||
| hideTimeout: 0, |
Contributor
Author
There was a problem hiding this comment.
This looks closer to what the Tooltip's delay prop is described as
ciampo
force-pushed
the
fix/tooltip-hide-on-blur
branch
from
35433ab to
28fd5e6
Compare
Contributor
Author
|
Closing for now in favor of #57345 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57206
What?
Add a new
hideOnBlurprop to theTooltipcomponent which forces the tooltip to hide when its anchor loses focusWhy?
By default, the tooltip closes when interacting with other elements in the same
window(see ariakit docs). This means that the tooltip will stay open when the wholewindowloses focus — for example, this happens when the whole browser loses keyboard focus, or even when moving focus to/from an iframe.But sometimes it's desirable to have the tooltip hide when its anchor loses focus, hence the addition of the
hideOnBlurpropHow?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast