Skip to content

GradientPicker: use index while iterating over gradient entries to avoid React "duplicated key" warning #57361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 4 commits into from
Dec 26, 2023
Merged

GradientPicker: use index while iterating over gradient entries to avoid React "duplicated key" warning #57361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
00f8a91
GradientPicker: use index while iterating over gradient entries to av…
t-hamano Dec 24, 2023
c762f54
Update changelog
t-hamano Dec 24, 2023
8e0bc66
Use slug instead of index as a key
t-hamano Dec 26, 2023
2eff803
Merge branch 'trunk' into gradient-picker/fix-duplicate-key
t-hamano Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
- `Truncate`: improve handling of non-string `children` ([#57261](https://github.com/WordPress/gutenberg/pull/57261)).
- `PaletteEdit`: Don't discard colors with default name and slug ([#54332](https://github.com/WordPress/gutenberg/pull/54332)).
- `RadioControl`: Fully encapsulate styles ([#57347](https://github.com/WordPress/gutenberg/pull/57347)).
- `GradientPicker`: Use slug while iterating over gradient entries to avoid React "duplicated key" warning ([#57361](https://github.com/WordPress/gutenberg/pull/57361)).

### Enhancements

Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/gradient-picker/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ function SingleOrigin( {
...additionalProps
}: PickerProps< GradientObject > ) {
const gradientOptions = useMemo( () => {
return gradients.map( ( { gradient, name }, index ) => (
return gradients.map( ( { gradient, name, slug }, index ) => (
<CircularOptionPicker.Option
key={ gradient }
key={ slug }
value={ gradient }
isSelected={ value === gradient }
tooltipText={
Expand Down