Skip to content

Commands: Combine selectors in 'useTransformCommands' #57424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 1 commit into from
Jan 3, 2024
Merged

Commands: Combine selectors in 'useTransformCommands' #57424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Commands: Combine selectors in 'useTransformCommands'
  • Loading branch information
@Mamaduka
Mamaduka committed Dec 28, 2023
commit ee8df806fe13353a9b0b5052b2cceefa63a2403c
39 changes: 18 additions & 21 deletions packages/block-editor/src/components/use-block-commands/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,40 +26,37 @@ import BlockIcon from '../block-icon';
import { store as blockEditorStore } from '../../store';

export const useTransformCommands = () => {
const { clientIds } = useSelect( ( select ) => {
const { getSelectedBlockClientIds } = select( blockEditorStore );
const selectedBlockClientIds = getSelectedBlockClientIds();

return {
clientIds: selectedBlockClientIds,
};
}, [] );
const blocks = useSelect(
( select ) =>
select( blockEditorStore ).getBlocksByClientId( clientIds ),
[ clientIds ]
);
const { replaceBlocks, multiSelect } = useDispatch( blockEditorStore );
const { possibleBlockTransformations, canRemove } = useSelect(
( select ) => {
const { blocks, clientIds, canRemove, possibleBlockTransformations } =
useSelect( ( select ) => {
const {
getBlockRootClientId,
getBlockTransformItems,
getSelectedBlockClientIds,
getBlocksByClientId,
canRemoveBlocks,
} = select( blockEditorStore );

const selectedBlockClientIds = getSelectedBlockClientIds();
const selectedBlocks = getBlocksByClientId(
selectedBlockClientIds
);
const rootClientId = getBlockRootClientId(
Array.isArray( clientIds ) ? clientIds[ 0 ] : clientIds
Copy link
Member

@tyxla tyxla Jan 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getSelectedBlockClientIds() will always be an array. Nice 👍

selectedBlockClientIds[ 0 ]
);
return {
blocks: selectedBlocks,
clientIds: selectedBlockClientIds,
possibleBlockTransformations: getBlockTransformItems(
blocks,
selectedBlocks,
rootClientId
),
canRemove: canRemoveBlocks(
selectedBlockClientIds,
rootClientId
),
canRemove: canRemoveBlocks( clientIds, rootClientId ),
};
},
[ clientIds, blocks ]
);
}, [] );

const isTemplate = blocks.length === 1 && isTemplatePart( blocks[ 0 ] );

Expand Down