Skip to content

File: Remove 'block-editor' store subscription #57511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 1 commit into from
Jan 4, 2024
Merged

File: Remove 'block-editor' store subscription #57511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
File: Remove 'block-editor' store subscription
  • Loading branch information
@Mamaduka
Mamaduka committed Jan 3, 2024
commit 08cdfbbf11a57ec3497f8b80c1fa54aee215bc4c
6 changes: 3 additions & 3 deletions packages/block-library/src/file/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,13 @@ function FileEdit( { attributes, isSelected, setAttributes, clientId } ) {
displayPreview,
previewHeight,
} = attributes;
const { media, mediaUpload } = useSelect(
const { getSettings } = useSelect( blockEditorStore );
const { media } = useSelect(
( select ) => ( {
media:
id === undefined
? undefined
: select( coreStore ).getMedia( id ),
mediaUpload: select( blockEditorStore ).getSettings().mediaUpload,
} ),
[ id ]
);
Expand All @@ -93,7 +93,7 @@ function FileEdit( { attributes, isSelected, setAttributes, clientId } ) {
if ( isBlobURL( href ) ) {
const file = getBlobByURL( href );

mediaUpload( {
getSettings().mediaUpload( {
filesList: [ file ],
onFileChange: ( [ newMedia ] ) => onSelectFile( newMedia ),
onError: onUploadError,
Expand Down