Remove LastFocus from Block Editor store in favor of useLastFocus #57557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds useLastFocus in the utils to store a lastFocus ref and a setLastFocus for setting the ref.
jeryj
requested review from
ajitbohra,
ellatrix,
fabiankaegy,
juanmaguitar,
ndiego and
ryanwelcher
as code owners
|
Size Change: +170 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
jeryj
added
[Type] Bug
jeryj
changed the title
youknowriad
reviewed
Jan 4, 2024
| * | ||
| * @return {Object} Object with a lastFocus ref and setLastFocus. | ||
| */ | ||
| const lastFocus = createRef(); |
Contributor
There was a problem hiding this comment.
Unfortunately, that is not a good approach because this is a global singleton, meaning that if you have multiple block editors in the same page, you'll end up with conflicts (they'll be sharing the same ref)
Contributor
Author
There was a problem hiding this comment.
Ah, I didn't consider multiple block editors on one page. Do you have any recommended routes to explore? I'll look at it again.
Contributor
There was a problem hiding this comment.
I'm not familiar enough with what we're trying to achieve here but a private selector/action could work without changing any logic.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds useLastFocus in the utils to store a lastFocus ref and a setLastFocus for setting the ref.
Why?
getLastFocus/setLastFocusfrom the public API per request.How?
Adds a
useLastFocusto the Block Editor utils as a global Ref that can be set like:Then retrieved via:
Testing Instructions for Keyboard
There should be no change from trunk. This mostly impacts pressing the Escape toolbar