Code Quality: Improve inserter pattern constants #57570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Code Quality
talldan
changed the title
talldan
requested review from
aaronrobertshaw,
glendaviesnz,
kevin940726,
ntsekouras and
oandregal
|
Size Change: -22 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Jan 5, 2024
This was referenced Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Across the codebase there were two constant objects called
PATTERN_TYPES, confusingly containing different values. This PR changes the name of the one defined inpackages/block-editor/src/components/inserter/block-patterns-tab/utils.jstoINSERTER_PATTERN_TYPESto help indicate that it's used for inserter items.I've also removed the 'synced' and 'unsynced' values from this constant which were unused.
I've removed the 'all' value from these constants, as this isn't a value that can be set on pattern inserter items. Instead this is a value that is used by the filter UI.
Finally, the
SYNC_TYPESconstant is renamed toINSERTER_SYNC_TYPES.