Skip to content

Post content block: create content select pattern placeholder #57572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ramonjd wants to merge 10 commits into from
Closed

Post content block: create content select pattern placeholder #57572

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
720b3c6
Initial commit - initial paragraph block can be selected.
ramonjd Jan 5, 2024
f1eb82a
Hacking to get patterns tab open. Need to head check this
ramonjd Jan 5, 2024
a13743b
Hacking to get patterns tab open. Need to head check this
ramonjd Jan 5, 2024
320d454
Adding styles
ramonjd Jan 9, 2024
4560881
Remove internal state, derive from props.
ramonjd Jan 9, 2024
062d123
Update docs
ramonjd Jan 9, 2024
d609677
Show the placeholder when the block has no blocks in the editor.
ramonjd Jan 9, 2024
f995eb3
Reverting hasInnerBlocks change to punt to another PR. It will requir…
ramonjd Jan 10, 2024
f7f0a92
updates nomenclature "category" > "tab"
ramonjd Jan 12, 2024
55e7342
Merge branch 'trunk' into try/post-content-select-pattern-placeholder
SaxonF Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Show the placeholder when the block has no blocks in the editor.
  • Loading branch information
@ramonjd
ramonjd committed Jan 12, 2024
commit d609677796ad7cd23c91a0f0c4bffb487d707817
27 changes: 7 additions & 20 deletions packages/block-library/src/post-content/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,7 @@ import {
Warning,
store as blockEditorStore,
} from '@wordpress/block-editor';
import {
useEntityProp,
useEntityBlockEditor,
store as coreStore,
} from '@wordpress/core-data';
import { useEntityProp, useEntityBlockEditor } from '@wordpress/core-data';
import { useSelect, useDispatch } from '@wordpress/data';
import { Placeholder, Button } from '@wordpress/components';
import { postContent as icon } from '@wordpress/icons';
Expand Down Expand Up @@ -105,23 +101,14 @@ function EditableContent( { context = {}, clientId } ) {
{ id: postId }
);

const { entityRecord, setInserterIsOpened } = useSelect(
( select ) => {
return {
entityRecord: select( coreStore ).getEntityRecord(
'postType',
postType,
postId
),
setInserterIsOpened:
select( blockEditorStore ).getSettings()
.__experimentalSetIsInserterOpened,
};
},
[ postType, postId ]
const setInserterIsOpened = useSelect(
( select ) =>
select( blockEditorStore ).getSettings()
.__experimentalSetIsInserterOpened,
[]
);

const hasInnerBlocks = !! entityRecord?.content?.raw || blocks?.length;
const hasInnerBlocks = !! blocks?.length;
Copy link
Member Author

@ramonjd ramonjd Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed this line so that the placeholder only cares whether the post content block has any child blocks, and will show even if there's saved post content.

This allows us to show the placeholder in the post editor in template preview mode as well.

Do folks see any downsides here?

Copy link
Member Author

@ramonjd ramonjd Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing E2E tests are real and I think due to this change.

I think maybe reverting this change and then do a quick follow up to this PR to avoid a large change set.

Copy link
Member Author

@ramonjd ramonjd Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted in 7560cba


const { children, ...props } = useInnerBlocksProps(
useBlockProps( {
Expand Down