Label the HeightControl. #57683
Merged
Label the HeightControl. #57683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: +2 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
This was referenced Jan 10, 2024
andrewserong
approved these changes
Jan 10, 2024
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this up!
Contributor
Author
|
Thanks for merging it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57681
What?
The HeightControl controls are unlabeled. This PR just passed the omitted
labelprop, together with thehideLabelFromVisionto visually hide the labels.Why?
Unlabeled controls can't be used by assistive technology users (screen readers, speech recognition) even if there's some other
visual labelingnearby.How?
Pass the omitted
labelprop to the HeightControl underlying components.Adds the
hideLabelFromVisionprop to visually hide the label elements.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast