Skip to content

Font Library: create font faces through the REST API #57702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
creativecoder merged 9 commits into from
Jan 11, 2024
Merged

Font Library: create font faces through the REST API #57702

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a147cbd
Create font faces and uploads working
creativecoder Jan 9, 2024
ef59b87
WP_REST_Font_Faces_Controller_Test::test_create_item in progress
creativecoder Jan 10, 2024
5cfcb0a
Working test_create_item
creativecoder Jan 10, 2024
f04e0fc
Font face controller complete?
creativecoder Jan 11, 2024
0b572b1
Adds additional tests
creativecoder Jan 11, 2024
a027f92
Use parent::create_item
creativecoder Jan 11, 2024
3fd8037
Remove unused test properties
creativecoder Jan 11, 2024
02728cf
Test tweaks
creativecoder Jan 11, 2024
e671e57
Fix phpcs warning
creativecoder Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test tweaks
  • Loading branch information
@creativecoder
creativecoder committed Jan 11, 2024
commit 02728cfdbb451e6d8fc8b501500f9f7132d24c45
4 changes: 3 additions & 1 deletion phpunit/tests/fonts/font-library/wpRestFontFacesController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,8 @@ public function test_create_item_default_theme_json_version() {
$data = $response->get_data();

$this->assertSame( 2, $data['theme_json_version'], 'The default theme.json version should be 2.' );

wp_delete_post( $data['id'], true );
}

/**
Expand Down Expand Up @@ -572,7 +574,7 @@ protected function check_font_face_data( $data, $post_id, $links ) {
$this->assertSame( $post->post_parent, $data['parent'] );

$this->assertArrayHasKey( 'theme_json_version', $data );
$this->assertSame( 2, $data['theme_json_version'] );
$this->assertSame( WP_Theme_JSON::LATEST_SCHEMA, $data['theme_json_version'] );

$this->assertArrayHasKey( 'font_face_settings', $data );
$this->assertSame( $post->post_content, wp_json_encode( $data['font_face_settings'] ) );
Expand Down