-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Font Library: Update uninstall/delete on client side #57932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mikachan
merged 10 commits into
try/font-library-refactor
from
font-library/update-delete-client-side
Jan 18, 2024
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9f7bde1
Fix delete endpoint
mikachan 1c9aa8d
Update fetchUninstallFontFamily to match new format
mikachan 9b90a18
Update uninstallFont
mikachan bcbbd81
Add uninstall notice back in
mikachan c96bf23
Tidy up comments
mikachan 454eb26
Re-word uninstall notices
mikachan 371a221
Add spacing to error message
mikachan 530939f
Refactored how font family values were processed so they would retain…
pbking 46124cb
Rename uninstallFont to uninstallFontFamily
mikachan bed9b8a
Throw uninstall errors rather than returning them
mikachan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Fix delete endpoint
- Loading branch information
commit 9f7bde1ecb7a4968aa861dac866109df5c92d872
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.