Tooltip and Button: tidy up unit tests #57975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Code Quality
ciampo
force-pushed
the
refactor/tooltip-button-unit-tests
branch
from
8688cd1 to
e4bc421
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As discussed in #57878 (comment), this PR:
Tooltiptests to use vanillabuttoninstead ofButtonButtoncomponent to test it in combination withTooltipWhy?
To keep
Tooltipfree from side-effects with other components (Button), but at the same time to make sure thatButtonworks as expected when nested in aTooltipHow?
By tweaking unit tests
Testing Instructions
Read code changes, make sure that tests keep passing.