Element: start reexporting PureComponent #58076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Enhancement
|
Size Change: +8 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jan 22, 2024
|
Flaky tests detected in 4c623f4f1eceae00426320869c4c89e657574167. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7612555314
|
tyxla
approved these changes
Jan 22, 2024
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
LGTM, thanks 👍
Perhaps we should link to the new docs site?
packages/element/README.md
Outdated
Member
There was a problem hiding this comment.
Perhaps we should link to the new docs:
Suggested change
| - <https://reactjs.org/docs/react-api.html#reactpurecomponent> | |
| - <https://react.dev/reference/react/PureComponent> |
Member
Author
There was a problem hiding this comment.
Perhaps we should link to the new docs:
Why not, but let's do it for all references, in its own PR. Searching for "reactjs.org/docs" shows me 100 references, in various JSDoc comments and Markdown documents.
Member
There was a problem hiding this comment.
Sounds good, although I didn't want to burden you with doing it for all existing usages 😅
packages/element/src/react.js
Outdated
Member
There was a problem hiding this comment.
Suggested change
| * @see https://reactjs.org/docs/react-api.html#reactpurecomponent | |
| * @see https://react.dev/reference/react/PureComponent |
jsnajdr
force-pushed
the
add/element-pure-component
branch
from
4c623f4 to
00e6671
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to discussion in #57173: start re-exporting
PureComponentfrom@wordpress/element. The goal is to keep parity withreact, without any gotchas or surprises.PureComponentis marked as "legacy API" by React docs, but so are all class component APIs likeComponentorcreateRef, and also functions likecloneElementwhich we use quite often. They are all still ubiquitous in a lot of React code.