-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Block Bindings: Disable editing of bound block attributes in editor UI #58085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
2f071ad
Add actions and selectors to register new sources
SantosGuillamot 57ab9b2
Add hook to read the bindings attribute in Edit
SantosGuillamot 445405f
Add context to all the blocks with bindings
SantosGuillamot af7f870
Lock rich text when `isContentBound` is true
SantosGuillamot c3567a4
Adapt paragraph and heading blocks UI
SantosGuillamot 35c8c64
Adapt button block UI
SantosGuillamot 989f456
Adapt image block UI
SantosGuillamot a4dc34a
Register post meta source
SantosGuillamot 3515538
Don't use placeholder if attribute is `src` or `href`
SantosGuillamot 41709fa
Always share placeholder in case meta is empty
SantosGuillamot 1567f17
Remove `keyToLabel` and use just label
SantosGuillamot 1984749
Remove source component until it is needed
SantosGuillamot 9644946
Use translations in the source label
SantosGuillamot 478f861
Move `select` inside `useSource`
SantosGuillamot 2acf6bd
Read `lockEditorUI` prop and add it for patterns
SantosGuillamot a8a6da3
Move logic to lock editing directly to RichText
SantosGuillamot 30b635e
Improve `useSelect` destructuring
SantosGuillamot a6f5fde
Load all image controls if attributes are bound
SantosGuillamot 7d0cb9a
Remove unnecessary condition
SantosGuillamot e6a5a4d
Move `lockAttributesEditing` to source definition
SantosGuillamot 7c1ca5a
Move `useSelect` into existing hook
SantosGuillamot 4246260
Fix `RichText` not being selected on click
SantosGuillamot 5a0cee8
Lock button and image controls only when selected
SantosGuillamot 54c313d
Remove unnecesarry optional chaining
SantosGuillamot aaf8652
Move `shouldDisableEditing` logic inside callback
SantosGuillamot 1f34e08
Merge branch 'trunk' into add/block-bindings-support-in-the-editor
SantosGuillamot 895e6dd
Fix formatting issue
SantosGuillamot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add context to all the blocks with bindings
- Loading branch information
commit 445405f4fe796edd0714012f86ac25f293e23312
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.