Merged
Conversation
dcalhoun
added
[Type] Automated Testing
2 tasks
|
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
The larger swipe distance results in faster scrolling, which will reduce the time it takes to scroll. The reduced time will mitigate the need to await longer scroll durations before asserting expectations and reduce test durations in general. Additionally, refactor both `swipeUp` and `swipeDown` to use an options parameter to communicate each argument intent, as well as improve alignment between the utilities.
All usage was removed in #52289. Additionally, the utility may be outdated and incompatible with the current editor UI.
dcalhoun
force-pushed
the
test/improve-e2e-test-stability
branch
from
ad3646c to
ef47386
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
What?
Improve E2E test stability and speed.
Why?
Long, unstable tests reduce confidence.
How?
test: Increase
swipeDownswipe distanceThe larger swipe distance results in faster scrolling, which will reduce
the time it takes to scroll. The reduced time will mitigate the need to
await longer scroll durations before asserting expectations and reduce
test durations in general.
Additionally, refactor both
swipeUpandswipeDownto use an optionsparameter to communicate each argument intent, as well as improve
alignment between the utilities.
test: Remove unused
removeBlockAtPositionutilityAll usage was removed in
#52289. Additionally, the
utility may be outdated and incompatible with the current editor UI.
Testing Instructions
N/A, CI checks should pass.
Testing Instructions for Keyboard
N/A, CI checks should pass.
Screenshots or screencast
N/A, no visual changes.