Skip to content

Removed color.__experimentalDuotone from core blocks #58241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
t-hamano merged 3 commits into from
Mar 10, 2025
Merged

Removed color.__experimentalDuotone from core blocks #58241

t-hamano merged 3 commits into from
Mar 10, 2025

Conversation

@sabbir1991
Copy link
Contributor

@sabbir1991 sabbir1991 commented Jan 25, 2024 •
edited
Loading

What?

In this PR I removed the color.__experimentalDuotone from a few core blocks( Avatar, Cover, Post author, Post featured image, and Site logo blocks ) and added filter.duotone supports.

Why?

The block supports color.__experimentalDuotone has been deprecated in WordPress 6.3. Thats why I removed those deprecated code and added filter support.

Fixes issue: #58035

Testing Instructions

  1. Open a post or page new/edit page.
  2. Insert Avatar/Cover/Post author/Post featured image/Site logo blocks for testing.
  3. Set the Duotone option from the toolbar or Sidebar color settings.
  4. Need to check whether the color is reflected on the editor or not.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 25, 2024
@github-actions
Copy link

github-actions bot commented Jan 25, 2024

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @sabbir1991! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@t-hamano
Copy link
Contributor

t-hamano commented Jul 28, 2024

Hi @sabbir1991,

All the changes made in this PR look correct, but there are conflicts, could you rebase this PR?

Thank you for your efforts!

@github-actions
Copy link

github-actions bot commented Jul 28, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sabbir1991 <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano linked an issue Jul 28, 2024 that may be closed by this pull request
Don't use deprecated color.__experimentalDuotone #58035
Closed
@sabbir1991 sabbir1991 force-pushed the fix/color-experimental-duotone-deprication branch from 8158083 to 5e938e2 Compare March 5, 2025 18:03
@sabbir1991
Copy link
Contributor Author

sabbir1991 commented Mar 6, 2025

Hi @t-hamano, I have rebased the changes with the latest trunk and updated the PR. Now this PR change is ready for review.

@t-hamano t-hamano added [Type] Code Quality Issues or PRs that relate to code quality Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Mar 6, 2025
t-hamano
t-hamano reviewed Mar 6, 2025
View reviewed changes
t-hamano
t-hamano approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your work 👍

@t-hamano t-hamano merged commit 2684096 into WordPress:trunk Mar 10, 2025
59 of 60 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.5 milestone Mar 10, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
@sabbir1991 @t-hamano @chriszarate
Removed color.__experimentalDuotone from core blocks (WordPress#58241)
00d27ce 
* Removed `color.__experimentalDuotone` from core blocks

* Fixed doc build issue

* Updated selector for rendering dutone filter on cover block globally

Co-authored-by: sabbir1991 <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@ndiego ndiego Awaiting requested review from ndiego

Assignees

No one assigned

Labels

[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Milestone

Gutenberg 20.5

Development

Successfully merging this pull request may close these issues.

Don't use deprecated color.__experimentalDuotone

2 participants

@sabbir1991 @t-hamano