Site Editor: Prevent classic theme from accessing global style menu #58345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +3 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
t-hamano
added
Global Styles
aaronrobertshaw
approved these changes
Jan 29, 2024
Contributor
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Thanks for the fix @t-hamano 👍
My understanding is that whether it supports the Global Styles or not is completely consistent with whether it's a block theme, so I updated it to only check if it's a block theme instead of supportsTemplatePartsMode.
Assuming I understood the original intent of #42729, I'd agree. In that light the changes here make sense to me.
✅ Changes LGTM
✅ Could replicate original issue
✅ Confirmed this PR resolves the issue
| Before | After |
|---|---|
 |
 |
Contributor
Author
|
@aaronrobertshaw Thanks for the review! |
carolinan
approved these changes
Jan 29, 2024
Contributor
carolinan
left a comment
carolinan
left a comment
There was a problem hiding this comment.
I tested this with a Twenty Twenty-One and Astra, a classic theme with theme.json.
With the PR I can no longer open the Styles sidebar.
Contributor
Author
|
@carolinan Thanks for the review! It seems that React Native E2E Tests are also failing on trunk, so I would like to update and merge this PR after that issue is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes an issue where classic themes could unintentionally access global styles when they get access to the Patterns page in the site editor in the future.
Why?
As indicated in this comment, the goal is for all Classic themes to have access to the Site Editor's Patterns page in the future.
As of WP6.5, access to this Pattern page is allowed internally, but I discovered that when I open the pattern editor canvas I can access the Global Styles menu.
My understanding is that the Global Styles is not expected to support the classic theme in the future, so this menu should not appear.
How?
Support for global styles currently relies on
supportsTemplatePartsModebeingfalse. This variable is determined by whether the theme is not classic and supports template parts:https://github.com/WordPress/wordpress-develop/blob/5c4b4887bf088b91df4f5e467b8982fa3b5441ec/src/wp-admin/site-editor.php#L64
The fact that
supportsTemplatePartsModeisfalsemeans that the following conditions are met:If the classic theme does not have template parts opted in, this condition is
false, which meanssupportsGlobalStylesistrue.My understanding is that whether it supports the Global Styles or not is completely consistent with whether it's a block theme, so I updated it to only check if it's a block theme instead of
supportsTemplatePartsMode.Testing Instructions
wp-admin/site-editor.phpto temporarily allow access:http://localhost:8888/wp-admin/site-editor.php?path=%2Fpatternsand create a pattern.