-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Interactivity Router: Move ARIA live region and loading bar to the Interactivity Router #58377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DAreRodz
merged 25 commits into
trunk
from
try/interactivity-router-a11y-and-loading-bar
Feb 2, 2024
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
66d0dbb
Expose state related to navigations
DAreRodz 07bbaad
Remove loading bar and aria region from query block
DAreRodz e56191d
Implement wp-router-region processor
DAreRodz c2ab4d2
Remove aria regions and loading bar logic from query block
DAreRodz e0fecdc
Move loading bar CSS from query to router region processor
DAreRodz 020e9c2
Recover `navigatingTo` variable
DAreRodz f45282b
Fix flaky test
DAreRodz 2f95ca7
Remove unnecessary PHPUnit checks
DAreRodz eb65d2b
Ensure the callback is executed once
DAreRodz 6ab84a1
Update boolean flags and message only if page exists
DAreRodz 1c4445f
Clarify usage of unresolved promise
DAreRodz f207a79
More code reordering
DAreRodz 56225f5
Save current link URL after navigating
DAreRodz 04ce0dd
Add topLoadingBar and screenReaderAnnounce options
DAreRodz 8217089
Fix url updating after navigating back or forward
DAreRodz 196634c
Rename internal `url` variable to `pagePath`
DAreRodz 4e7660f
Always set a string in `state.url`
DAreRodz ab00ba8
Remove confusing comment
DAreRodz 1960203
Use internal state instance instead of `wp_interactivity_state`
DAreRodz a13b08c
Add id to the router animations style tag
DAreRodz 9917541
Test the `data-wp-router-region` directive processor
DAreRodz e63e717
Rename topLoadingBar option to loadingAnimation
DAreRodz 7d64b03
Update docs for options.loadingAnimation
DAreRodz bd3842c
Move router-region flag to the WP_Interactivity_API class
DAreRodz e08f981
Fix screenReaderAnnouncement name
DAreRodz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Implement wp-router-region processor
- Loading branch information
commit e56191df89bcc4c44d26e3aabec742c4b2944717
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.