Interactivity API: Server Directive Processor for data-wp-each
#58498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisherranz
added
[Type] Enhancement
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.5/compat.php ❔ lib/experimental/interactivity-api.php ❔ phpunit/interactivity-api/class-wp-interactivity-api-wp-each-test.php ❔ lib/compat/wordpress-6.5/interactivity-api/class-wp-interactivity-api-directives-processor.php ❔ lib/compat/wordpress-6.5/interactivity-api/class-wp-interactivity-api.php ❔ lib/load.php ❔ phpunit/interactivity-api/class-wp-interactivity-api-directives-processor-test.php ❔ phpunit/interactivity-api/class-wp-interactivity-api-test.php ❔ phpunit/interactivity-api/class-wp-interactivity-api-wp-text-test.php |
47 tasks
|
Flaky tests detected in 4a62bb6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7725949372
|
DAreRodz
approved these changes
Jan 31, 2024
Contributor
DAreRodz
left a comment
DAreRodz
left a comment
There was a problem hiding this comment.
The code and tests look great. 👏
PS: I've left some nitpicky suggestions.
phpunit/interactivity-api/class-wp-interactivity-api-directives-processor-test.php
Outdated
Show resolved
Hide resolved
phpunit/interactivity-api/class-wp-interactivity-api-directives-processor-test.php
Show resolved
Hide resolved
phpunit/interactivity-api/class-wp-interactivity-api-wp-each-test.php
Outdated
Show resolved
Hide resolved
8 tasks
Member
Author
|
Thanks David! Feedback addressed. |
luisherranz
requested review from
Mamaduka,
ajitbohra,
kevin940726,
nerrad and
ntwb
as code owners
|
Size Change: +44 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
Member
Author
|
Let's port this to core and continue working there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking Issue: #56803
What?
This PR adds an additional server directive processor to process the
data-wp-eachdirective, introduced in:wp-eachdirective #57859Why?
Because all the directives that modify the markup should be processed in the server to avoid layout shifts.
How?
By introducing a new method to append content after the closing tag of balanced tags (or after a void tag) and refactoring the
process_directivemethod to be used internally with the inner content of thetemplatethat contains thedata-wp-eachdirective.It also makes the
next_balanced_tag_closer_tagpublic (but with@access private) to be able to jump from top-level nodes and add the correspondingdata-wp-each-childdirectives, which are required during the frontend hydration.This PR also includes a
compatversion of the fallback of the native PHP8array_is_listfunction which is going to be introduced in WP 6.5.Testing Instructions
data-wp-eachdirective and pass a reference to an array.templatetag are properly rendered.