Skip to content

Block Bindings: Add block context needed for bindings in PHP #58554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SantosGuillamot merged 20 commits into from
Feb 16, 2024
Merged

Block Bindings: Add block context needed for bindings in PHP #58554

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
247194d
Modify `uses_context` for allowed blocks in PHP
SantosGuillamot Feb 9, 2024
98e7757
Update post meta source to use block context
SantosGuillamot Feb 9, 2024
38b539d
Remove old hook used for the editor
SantosGuillamot Feb 9, 2024
4194fcd
Remove possibility of passing post id from source
SantosGuillamot Feb 9, 2024
3a8acd6
Set correct post id
SantosGuillamot Feb 9, 2024
0534638
Adapt post meta source
SantosGuillamot Feb 9, 2024
31def4b
Adapt pattern overrides source
SantosGuillamot Feb 9, 2024
6cb23c5
Remove old usesContext from block.json
SantosGuillamot Feb 9, 2024
1dbf2c4
Remove old filter
SantosGuillamot Feb 9, 2024
3a17b09
Add backport to `uses_context` in source registration
SantosGuillamot Feb 12, 2024
4cb4dc6
Update source class to include `uses_context`
SantosGuillamot Feb 13, 2024
aa39f96
Use `get_block_type_uses_context` when available
SantosGuillamot Feb 13, 2024
d8886e8
Use `empty` function in post meta source
SantosGuillamot Feb 13, 2024
8dae652
Update descriptions
SantosGuillamot Feb 13, 2024
9252a37
Update $supported_blocks variable name
SantosGuillamot Feb 13, 2024
058fa6e
Use `in_array` properly
SantosGuillamot Feb 13, 2024
a77a9ce
Update bindings registry comments
SantosGuillamot Feb 13, 2024
63b790e
Update allowed_blocks variable name
SantosGuillamot Feb 13, 2024
e557ab3
Check allowed properties in the registry
SantosGuillamot Feb 16, 2024
d0c3e9e
Use only compatibility filter
SantosGuillamot Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update $supported_blocks variable name
  • Loading branch information
@SantosGuillamot
SantosGuillamot committed Feb 13, 2024
commit 9252a376bf40301439d2a79b2f1ebe034e839abb
4 changes: 2 additions & 2 deletions lib/compat/wordpress-6.5/block-bindings/class-wp-block-bindings-registry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,9 @@ function ( $uses_context, $block_type ) use ( $source ) {
add_filter(
'register_block_type_args',
function ( $args, $block_name ) use ( $source ) {
$allowed_blocks = $this->allowed_blocks;
$supported_blocks = $this->supported_blocks;

if ( empty( $allowed_blocks[ $block_name ] ) || empty( $source->uses_context ) ) {
if ( empty( $supported_blocks[ $block_name ] ) || empty( $source->uses_context ) ) {
return $args;
}
$original_use_context = isset( $args['uses_context'] ) ? $args['uses_context'] : array();
Expand Down