Skip to content

Font Library Address Outstanding Feedback from WP 6.4 review #58675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
getdave merged 8 commits into from
Feb 5, 2024
Merged

Font Library Address Outstanding Feedback from WP 6.4 review #58675

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
20cbc75
Translate error string
getdave Feb 5, 2024
4f846fa
Improve get_allowed_font_mime_types comment
creativecoder Feb 5, 2024
82c04d5
Use str_contains rather than strpos
creativecoder Feb 5, 2024
e187b03
Move period outside double quotes
getdave Feb 5, 2024
ab62473
Correct error message
creativecoder Feb 5, 2024
f6f513f
Use sprintf for parameter names in translated strings
creativecoder Feb 5, 2024
59e6fde
Capitalize HTTP
creativecoder Feb 5, 2024
28bbc36
Updates tests
creativecoder Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Correct error message
  • Loading branch information
@creativecoder
creativecoder committed Feb 5, 2024
commit ab62473df15d54f8ccfe96e1770294581593cd07
2 changes: 1 addition & 1 deletion lib/compat/wordpress-6.5/fonts/class-wp-font-collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ private function load_from_url( $url ) {

$data = json_decode( wp_remote_retrieve_body( $response ), true );
if ( empty( $data ) ) {
return new WP_Error( 'font_collection_decode_error', __( 'Error decoding the font collection data from the REST response JSON.', 'gutenberg' ) );
return new WP_Error( 'font_collection_decode_error', __( 'Error decoding the font collection data from the http response JSON.', 'gutenberg' ) );
Copy link
Member

@swissspidy swissspidy Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd assume HTTP to be capitalized here.

Copy link
Contributor

@matiasbenedetto matiasbenedetto Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated here: 59e6fde

}

// Make sure the data is valid before storing it in a transient.
Expand Down