Skip to content

Font Library: address feedback from wordpress-develop#6027 #58691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
creativecoder merged 9 commits into from
Feb 5, 2024
Merged

Font Library: address feedback from wordpress-develop#6027 #58691

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6c12848
Removes unneeded comment in wp_get_font_dir
creativecoder Feb 5, 2024
fc3f6fc
Move font collection slug check to immediately after slug is assigned
creativecoder Feb 5, 2024
b8db2bd
Fix translators comment indentation
creativecoder Feb 5, 2024
3c6d65d
Remove unneeded colon from error message
creativecoder Feb 5, 2024
b51db01
Use is_collection_registered in get_font_collection
creativecoder Feb 5, 2024
59478bc
Removes extra line in WP_Font_Library::$collections docblock
creativecoder Feb 5, 2024
6248778
Use variable for font_dir so function isn't called repeatedly within …
creativecoder Feb 5, 2024
b27b0ad
Adds empty line before the return of WP_Font_Collection::get_data
creativecoder Feb 5, 2024
4d8472a
Uses static closure in font collection sanitization schema
creativecoder Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use variable for font_dir so function isn't called repeatedly within … 
…loop
  • Loading branch information
@creativecoder
creativecoder committed Feb 5, 2024
commit 62487785d063292c9f76ed726687ade8684afc0b
3 changes: 2 additions & 1 deletion lib/compat/wordpress-6.5/fonts/fonts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,9 +257,10 @@ function _wp_before_delete_font_face( $post_id, $post ) {
}

$font_files = get_post_meta( $post_id, '_wp_font_face_file', false );
$font_dir = wp_get_font_dir()['path'];

foreach ( $font_files as $font_file ) {
wp_delete_file( wp_get_font_dir()['path'] . '/' . $font_file );
wp_delete_file( $font_dir . '/' . $font_file );
}
}
add_action( 'before_delete_post', '_wp_before_delete_font_face', 10, 2 );
Expand Down