Font Library: remove tests from classes that were already merged in core

[matiasbenedetto]

What?

Remove tests from classes that were recently merged in core: WordPress/wordpress-develop#6027

Why?

Updated tests fail if something of the class in Gutenberg repo change because the code used to run the tests come from core and not from the class in this repo.

Suggested here: #58735 (comment)

How?

Removing the tests

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

Core Committers: Use this line as a base for the props when committing in SVN:

Props mmaattiiaass, youknowriad, grantmkin.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: matiasbenedetto <[email protected]>
Co-authored-by: youknowriad <[email protected]>
Co-authored-by: creativecoder <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[youknowriad]

LGTM

[youknowriad]

Interesting that removing unit tests actually trigger failures in other unit tests. There might be some dependency between multiple tests? (which is not great)

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ phpunit/tests/fonts/font-library/wpRestFontCollectionsController.php

[matiasbenedetto]

Interesting that removing unit tests actually trigger failures in other unit tests. There might be some dependency between multiple tests? (which is not great)

phpunit/tests/fonts/font-library/wpFontLibrary/base.php was resetting the list of registered collections. After deleting it, the default collection was registered, so the test failed. This commit fixes the problem by resetting the collections registered before running the rest tests: 6c30f76

[creativecoder]

This commit fixes the problem by resetting the collections registered before running the rest tests

Nice, this is an important addition. Let's make sure it gets into the Core PR, as it allows running the REST API tests independently without error.