Skip to content

DataViews: set color for primary field/a element when focused #58814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oandregal merged 6 commits into from
Feb 29, 2024
Merged

DataViews: set color for primary field/a element when focused #58814

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
977ca35
Set color for primary field/a element when focused
oandregal Feb 8, 2024
33e5b47
Improve how it looks
oandregal Feb 8, 2024
a7ae780
Use outer box-shadow
oandregal Feb 8, 2024
af0f332
Small fix.
jasmussen Feb 9, 2024
6ade827
Move to mixins in base-styles
oandregal Feb 16, 2024
0539c85
Remove unnecessary comment
oandregal Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve how it looks
  • Loading branch information
@oandregal
oandregal committed Feb 29, 2024
commit 33e5b477c0eb4ca66d68da09f37ec99f7fc41847
3 changes: 2 additions & 1 deletion packages/dataviews/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,8 @@
}
&:focus {
color: var(--wp-admin-theme-color--rgb);
Copy link
Member Author

@oandregal oandregal Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced this is the right approach/color combination.

Copy link
Member Author

@oandregal oandregal Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the fix, I wonder how 3rd parties can provide their own theming. We have a mix of approaches:

  • in some places, dataviews uses the @wordpress/component variables and fallback to wp-admin theme.
  • in some other, dataviews uses the wp-admin theme custom properties directly.

box-shadow: 0 0 0 var(--wp-admin-border-width-focus) var(--wp-admin-theme-color);
box-shadow: inset 0 0 0 var(--wp-admin-border-width-focus) var(--wp-components-color-accent, var(--wp-admin-theme-color, #007cba));
border-radius: $grid-unit-05;
}
}

Expand Down