Interactivity API: Move Core implementation to compat 6.5 folder #58829
Conversation
DAreRodz
added
[Type] Build Tooling
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.5/interactivity-api/class-wp-interactivity-api-directives-processor.php ❔ lib/compat/wordpress-6.5/interactivity-api/class-wp-interactivity-api.php ❔ lib/compat/wordpress-6.5/interactivity-api/interactivity-api.php ❔ lib/experimental/interactivity-api.php |
| * @param string $url The URL of the enqueued script. | ||
| * @return string The new Gutenberg URL if it's a match, or the WordPress Core URL otherwise. | ||
| */ | ||
| function gutenberg_interactivity_override_script_module_urls( $url ) { |
There was a problem hiding this comment.
Why is this file still in experimental? Is it something that will remain in Gutenberg forever? Should it move to compat folder.
There was a problem hiding this comment.
This PR will remove that file and move to the external folder:
#58830
|
Looks like there's still some e2e test failures. |
|
They don't look related to the Interactivity API. |
|
e2e test failures do indeed look like problems with Synced Pattern work which seems unrelated. Can we force merge this PR to unblock the PHP unit tests? |
|
Actually I noticed the e2e tests seem to fail on REST API errors. Is there some conflict here causing REST to fail? |
|
Ok, so I forced merged this to fix the php unit test but let's continue on the e2e tests, they seem block bindings related. |
What?
Updates all the Interactivity API PHP files implementation in Gutenberg using the current one in WordPress core (implemented in WordPress/wordpress-develop#5953).
All the related PHPUnit files are not needed anymore in Gutenberg, as there are tests in WordPress core for all features.