Docs: Clarify the status of the wp-block-styles theme support, and its intent #58915
Conversation
…s intent to be used in classic themes
andrewserong
added
the
[Type] Developer Documentation
andrewserong
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar,
ndiego and
ryanwelcher
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Can there be a new subheading above this section, because it can still read as if |
|
Oh, great point @carolinan! I've added an |
Co-authored-by: Ramon <[email protected]>
|
Thanks for the review @ramonjd! This PR isn't urgent, so I'll leave it overnight in case there's any other feedback, and then will merge it in tomorrow. |
andrewserong
deleted the
update/clarify-the-intent-behind-the-wp-block-styles-theme-support
branch
* trunk: (273 commits) Remove preffered style variations legacy support (#58930) Style theme variations: add property extraction and merge utils (#58803) Migrate `change-detection` to Playwright (#58767) Update Changelog for 17.6.6 Docs: Clarify the status of the wp-block-styles theme support, and its intent (#58915) Use `data_wp_context` helper in core blocks and remove `data-wp-interactive` object (#58943) Try double enter for details block. (#58903) Template revisions API: move from experimental to compat/6.4 (#58920) Editor: Remove inline toolbar preference (#58945) Clean up link control CSS. (#58934) Font Library: Show error message when no fonts found to install (#58914) Block Bindings: lock editing of blocks by default (#58787) Editor: Remove the 'all' rendering mode (#58935) Pagination Numbers: Add `data-wp-key` to pagination numbers if enhanced pagination is enabled (#58189) Close link preview if collapsed selection when creating link (#58896) Fix incorrect useAnchor positioning when switching from virtual to rich text elements (#58900) Upgrade Floating UI packages, fix nested iframe positioning bug (#58932) Site editor: fix start patterns store selector (#58813) Revert "Rich text: pad multiple spaces through en/em replacement (#56341)" (#58792) Documentation: Clarify the performance reference commit and how to pick it (#58927) ...
What?
Update the docs for the
wp-block-stylestheme support to clarify its intent to be used in classic themes, and that block themes should be adding styles totheme.jsoninstead of depending on the opinionated styles of this theme support feature.Why?
Thanks to @simison for flagging that the docs here don't nudge anyone toward baking desired styles in to
theme.jsonfor block themes. While it might be easier for themes to use this theme support, they're not guaranteed to work well with block themes or to avoid styling conflicts with rules from global styles.How?
Update the docs hosted at: https://developer.wordpress.org/block-editor/how-to-guides/themes/theme-support/#default-block-styles
Testing Instructions
Does this read okay, and is the information accurate? I've based that changes here on discussions from @carolinan and @tellthemachines, in particular on #57841 (comment), but it'd be good to double-check that I got the overall idea right, as I could very well be missing some context about this theme support!
Testing Instructions for Keyboard
Screenshots or screencast