Font face permissions #58957
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,8 @@ import { | |
| Modal, | ||
| privateApis as componentsPrivateApis, | ||
| } from '@wordpress/components'; | ||
| import { useSelect } from '@wordpress/data'; | ||
| import { store as coreStore } from '@wordpress/core-data'; | ||
| import { useContext } from '@wordpress/element'; | ||
|
|
||
| /** | ||
|
|
@@ -24,6 +26,9 @@ const DEFAULT_TABS = [ | |
| id: 'installed-fonts', | ||
| title: __( 'Library' ), | ||
| }, | ||
| ]; | ||
|
|
||
| const UPLOAD_TABS = [ | ||
| { | ||
| id: 'upload-fonts', | ||
| title: __( 'Upload' ), | ||
|
|
@@ -45,9 +50,15 @@ function FontLibraryModal( { | |
| } ) { | ||
| const { collections, setNotice } = useContext( FontLibraryContext ); | ||
|
|
||
| const canUserCreate = useSelect( ( select ) => { | ||
| const { canUser } = select( coreStore ); | ||
| return canUser( 'create', 'font-families' ); | ||
| } ); | ||
peterwilsoncc marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| const tabs = [ | ||
| ...DEFAULT_TABS, | ||
| ...( canUserCreate ? UPLOAD_TABS : [] ), | ||
| ...( canUserCreate ? tabsFromCollections( collections || [] ) : [] ), | ||
| ]; | ||
|
|
||
| // Reset notice when new tab is selected. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,8 @@ import { | |
| Spinner, | ||
| FlexItem, | ||
| } from '@wordpress/components'; | ||
| import { store as coreStore } from '@wordpress/core-data'; | ||
| import { useSelect } from '@wordpress/data'; | ||
|
|
||
| /** | ||
| * Internal dependencies | ||
|
|
@@ -100,6 +102,7 @@ function InstalledFonts() { | |
| handleBack={ !! libraryFontSelected && handleUnselectFont } | ||
| footer={ | ||
| <Footer | ||
| libraryFontSelected={ libraryFontSelected } | ||
| shouldDisplayDeleteButton={ shouldDisplayDeleteButton } | ||
| handleUninstallClick={ handleUninstallClick } | ||
| /> | ||
|
|
@@ -170,14 +173,30 @@ function InstalledFonts() { | |
| ); | ||
| } | ||
|
|
||
| function Footer( { | ||
| shouldDisplayDeleteButton, | ||
| handleUninstallClick, | ||
| libraryFontSelected, | ||
| } ) { | ||
| const { saveFontFamilies, fontFamiliesHasChanges, isInstalling } = | ||
| useContext( FontLibraryContext ); | ||
|
|
||
| const customFontFamilyId = | ||
| libraryFontSelected?.source === 'custom' && libraryFontSelected?.id; | ||
|
|
||
| const canUserDelete = useSelect( ( select ) => { | ||
| const { canUser } = select( coreStore ); | ||
| return ( | ||
| customFontFamilyId && | ||
| canUser( 'delete', 'font-families', customFontFamilyId ) | ||
| ); | ||
| } ); | ||
|
|
||
| return ( | ||
| <HStack justify="flex-end"> | ||
| { isInstalling && <ProgressBar /> } | ||
| <div> | ||
| { canUserDelete && shouldDisplayDeleteButton && ( | ||
| <Button | ||
| isDestructive | ||
| variant="tertiary" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,8 @@ import { | |
| FlexItem, | ||
| privateApis as componentsPrivateApis, | ||
| } from '@wordpress/components'; | ||
| import { store as coreStore } from '@wordpress/core-data'; | ||
| import { useSelect } from '@wordpress/data'; | ||
| import { useContext, useState } from '@wordpress/element'; | ||
|
|
||
| /** | ||
|
|
@@ -31,6 +33,11 @@ function UploadFonts() { | |
| const { installFont, notice, setNotice } = useContext( FontLibraryContext ); | ||
| const [ isUploading, setIsUploading ] = useState( false ); | ||
|
|
||
| const canUserCreate = useSelect( ( select ) => { | ||
| const { canUser } = select( coreStore ); | ||
| return canUser( 'create', 'font-families' ); | ||
| } ); | ||
|
|
||
| const handleDropZone = ( files ) => { | ||
| handleFilesUpload( files ); | ||
| }; | ||
|
|
@@ -171,41 +178,43 @@ function UploadFonts() { | |
| }; | ||
|
|
||
| return ( | ||
| canUserCreate && ( | ||
| <TabPanelLayout notice={ notice }> | ||
| <DropZone onFilesDrop={ handleDropZone } /> | ||
| <VStack className="font-library-modal__local-fonts"> | ||
| { isUploading && ( | ||
| <FlexItem> | ||
| <div className="font-library-modal__upload-area"> | ||
| <ProgressBar /> | ||
| </div> | ||
| </FlexItem> | ||
| ) } | ||
| { ! isUploading && ( | ||
| <FormFileUpload | ||
| accept={ ALLOWED_FILE_EXTENSIONS.map( | ||
| ( ext ) => `.${ ext }` | ||
| ).join( ',' ) } | ||
| multiple={ true } | ||
| onChange={ onFilesUpload } | ||
| render={ ( { openFileDialog } ) => ( | ||
| <Button | ||
| className="font-library-modal__upload-area" | ||
| onClick={ openFileDialog } | ||
| > | ||
| { __( 'Upload font' ) } | ||
| </Button> | ||
| ) } | ||
| /> | ||
| ) } | ||
| <Spacer margin={ 2 } /> | ||
| <Text className="font-library-modal__upload-area__text"> | ||
| { __( | ||
| 'Uploaded fonts appear in your library and can be used in your theme. Supported formats: .tff, .otf, .woff, and .woff2.' | ||
| ) } | ||
| </Text> | ||
| </VStack> | ||
| </TabPanelLayout> | ||
| ) | ||
| ); | ||
| } | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.