Theme JSON Tests: Refactor base styles to a static variable #58975
Conversation
scruffian
added
the
[Type] Code Quality
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ phpunit/class-wp-theme-json-test.php |
|
Flaky tests detected in 5229091. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7889030292
|
carolinan
changed the title
MaggieCabrera
added
[Type] Automated Testing
MaggieCabrera
left a comment
MaggieCabrera
left a comment
There was a problem hiding this comment.
So much cleaner now, thank you!
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
+1 this makes it so much easier to read! |
What?
Moves the bases styles string to a static variable.
Why?
Just keeps the code cleaner.
How?
Puts the string into a static variable.
Testing Instructions
Run the tests:
npm run test:unit:php:base -- --filter WP_Theme_JSON_Gutenberg_Test