Skip to content

Patterns: Avoid showing block removal warning when deleting a pattern instance that has overrides #59044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
talldan merged 2 commits into from
Feb 15, 2024
Merged

Patterns: Avoid showing block removal warning when deleting a pattern instance that has overrides #59044

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
114537b
Check we are not within a pattern instance before running block delet…
glendaviesnz Feb 14, 2024
72b5b6b
Make comment more explanatory
glendaviesnz Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Check we are not within a pattern instance before running block delet… 
…ion rules on overridden blocks
  • Loading branch information
@glendaviesnz
glendaviesnz committed Feb 14, 2024
commit 114537b815bbd080e9a3f72a3d392d5fa27602b8
9 changes: 9 additions & 0 deletions packages/block-editor/src/store/private-actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,15 @@ export const privateRemoveBlocks =
}

if ( rules[ 'bindings/core/pattern-overrides' ] ) {
const parentPatternBlocks =
select.getBlockParentsByBlockName(
clientId,
'core/block'
);
// If the overriden block is a child of a core/block, skip it.
if ( parentPatternBlocks?.length > 0 ) {
continue;
}
Comment on lines +143 to +151
Copy link
Copy Markdown
Contributor

@talldan talldan Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess another way is to only have the pattern overrides rule when within a pattern.

No real preference here, but I think it might affect the follow up that's underway.

const blockAttributes =
select.getBlockAttributes( clientId );
if (
Expand Down