Skip to content

After Enter transform, skip other onEnter actions like splitting #59064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsnajdr merged 1 commit into from
Feb 16, 2024
Merged

After Enter transform, skip other onEnter actions like splitting #59064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/block-editor/src/components/rich-text/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@ export function RichTextWrapper(
transformation.transform( { content: value.text } ),
] );
__unstableMarkAutomaticChange();
return;
Copy link
Member Author

@jsnajdr jsnajdr Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This leads to the onCustomEnter handler not being called, but that should be OK. If I understand correctly, it's used to handle things like list splitting (#43949).

Copy link
Member

@dcalhoun dcalhoun Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The #43949 test plan succeeds for me on an iPhone 15 Pro simulator.

}
}

Expand Down
1 change: 1 addition & 0 deletions packages/block-editor/src/components/rich-text/use-enter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ export function useEnter( props ) {
} ),
] );
__unstableMarkAutomaticChange();
return;
}
}

Expand Down