Navigation Block: Polish Block Hooks integration #59177
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Feature] Block API
Contributor
Author
|
cc/ @tjcafferkey -- Curious if you think this makes sense or if we should abandon it 🙂 |
|
Flaky tests detected in 5207cac. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7960966803
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
WIP. Potential follow-up to #59021.
Why?
For more consistency in some of our helpers.
How?
By stripping the mock Navigation root block from the return value of
block_core_navigation_insert_hooked_blocks.The downside is that it's now less consistent with
block_core_navigation_set_ignored_hooked_blocks_metadata. We might want to figure out a way around that; possibly by inlining the latter into the function that calls it.Testing Instructions
See e.g. #59021.