Skip to content

Block Bindings: Don't show protected fields that are bound to blocks #59326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SantosGuillamot merged 9 commits into from
Feb 28, 2024
Merged

Block Bindings: Don't show protected fields that are bound to blocks #59326

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b1e87cf
Check if the meta field is protected
SantosGuillamot Feb 23, 2024
7734683
Check if the meta field is available in the REST API
SantosGuillamot Feb 23, 2024
f8eab39
Use `get_registered_meta_keys` function
SantosGuillamot Feb 23, 2024
1117928
Return empty string instead of null
SantosGuillamot Feb 23, 2024
8da1667
Return null if the bindings config is not correct
SantosGuillamot Feb 26, 2024
b667e5c
Return `null` when the field is unavailable or protected
SantosGuillamot Feb 27, 2024
8697058
Add tests for protected fields
SantosGuillamot Feb 27, 2024
5eda970
Update tests to match current behavior
SantosGuillamot Feb 28, 2024
471745d
Remove unnecessary `show_in_rest` conditional
SantosGuillamot Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove unnecessary show_in_rest conditional 
Co-authored-by: Pascal Birchler <pascalb@google.com>
  • Loading branch information
@SantosGuillamot @swissspidy
SantosGuillamot and swissspidy authored Feb 28, 2024
commit 471745df93299c16abd4eecb9f88f545d6e6c30c
2 changes: 1 addition & 1 deletion lib/compat/wordpress-6.5/block-bindings/post-meta.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function gutenberg_block_bindings_post_meta_callback( $source_attrs, $block_inst
$meta_keys = get_registered_meta_keys( 'post', $block_instance->context['postType'] );
// Add fields registered for all subtypes.
$meta_keys = array_merge( $meta_keys, get_registered_meta_keys( 'post', '' ) );
if ( empty( $meta_keys[ $source_attrs['key'] ]['show_in_rest'] ) || false === $meta_keys[ $source_attrs['key'] ]['show_in_rest'] ) {
if ( empty( $meta_keys[ $source_attrs['key'] ]['show_in_rest'] ) ) {
return null;
}

Expand Down