Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
475fad1
Search block: use font size for search icon (#59159)
ramonjd Feb 22, 2024
266b4d2
Add missing empty space to print out valid HTML. (#59255)
juanfra Feb 22, 2024
12436cb
Featured Image & Post Title: Hide non content controls when block edi…
noisysocks Feb 23, 2024
83ef19f
Style Book: should persist when browsing global styles panels (#59261)
ramonjd Feb 23, 2024
52c4570
Shadows: Improve accessibility of shadows dropdown (#58828)
madhusudhand Feb 23, 2024
0086001
Fix query loop with block bindings not working in the editor as expec…
SantosGuillamot Feb 23, 2024
d59ab95
Update pages dataview icons, add 'drafts' icon (#59285)
jameskoster Feb 23, 2024
57030d3
Display all checkboxes when a single item is selected (#59233)
jameskoster Feb 23, 2024
5d4028f
Revert removal of Nav fallback auto embed (#59220)
getdave Feb 23, 2024
d56a480
update schema to accommodate the changes made in wp_register_font_col…
matiasbenedetto Feb 23, 2024
eadfe88
Update filter control position (#59231)
jameskoster Feb 23, 2024
900a55b
Fix: Multi line comment format on footnotes format. (#59312)
jorgefilipecosta Feb 23, 2024
56c8292
Disable selection checkbox if no bulk actions are eligible (#58950)
jorgefilipecosta Feb 23, 2024
6198eb0
Shadow: Fix layout collapse when indicator is selected (#59309)
t-hamano Feb 24, 2024
5191efd
Cover block: Clear aspect ratio value when toggling full height (#59296)
andrewserong Feb 25, 2024
a446441
Disable core shadow presets by default, let themes opt-in (#58766)
madhusudhand Feb 26, 2024
a3ab0c7
Block Hooks: Take controlled blocks into account for toggle state (#5…
ockham Feb 26, 2024
698ec96
Block Hooks: Add help text to Plugins panel. (#59371)
ockham Feb 26, 2024
3c1c03a
Update sidebar titles for Template and Page management data views (#5…
jameskoster Feb 26, 2024
8646cd1
Updates isEditingTemplate to check for `wp_template` post type instea…
mattgrshaw Feb 26, 2024
b9020fa
Fix `DisableNonPageContentBlocks` (#59297)
noisysocks Feb 27, 2024
d9a49b4
Cover Block: Restore overflow: clip rule to allow border radius again…
andrewserong Feb 27, 2024
65a8496
set border panel label based on the controls available (#59358)
madhusudhand Feb 27, 2024
709a7ae
Reposition pattern detail icon (#59363)
jameskoster Feb 27, 2024
6a04d6f
Font Library: add option to revoke access to Google Fonts (#59205)
carolinan Feb 23, 2024
915c75e
Use NavigatorProvider in Font Library Modal (#59036)
pbking Feb 23, 2024
ba6f31c
Editor: Limit spotlight mode to the editor. (#58817)
juanfra Feb 14, 2024
6dca770
DataViews: Fix pages list back path (#59201)
ntsekouras Feb 20, 2024
6912e21
Interactivity API: Only add proxies to plain objects inside the store…
cbravobernal Feb 20, 2024
1fa7012
Cover block: clear the min height field when aspect ratio is set (#59…
andrewserong Feb 21, 2024
c515c6c
Block Mover: Unify visual separator when show button label is on (#59…
t-hamano Feb 21, 2024
36237f0
Fix resetting individual blocks to empty values for Pattern Overrides…
kevin940726 Feb 21, 2024
c87e94c
Patterns: disable image caption if part of synced pattern (#58916)
glendaviesnz Feb 21, 2024
71746c4
Remove unneeded pattern overrides translation strings (#59269)
kevin940726 Feb 22, 2024
667797e
Fix Navigation link control overlapping issue (#59065)
akasunil Feb 22, 2024
6a8bf9d
Preserve bindings metadata in block transforms (#59179)
SantosGuillamot Feb 22, 2024
8374560
Interactivity API: Improve context merges using proxies (#59187)
DAreRodz Feb 22, 2024
ed1e641
Top Toolbar: Fix 'collapsed' state synchronization (#59267)
Mamaduka Feb 22, 2024
a51059c
Interactivity API: Prevent unwanted subscriptions to inherited contex…
DAreRodz Feb 22, 2024
eddf324
URLPopover: restore min-width style (#59274)
t-hamano Feb 22, 2024
3bf1514
Apply hover styles to filter chip while being configured (#59236)
jameskoster Feb 22, 2024
afff734
Update page selector (#59284)
jameskoster Feb 22, 2024
ae25e5a
Block bindings: fix Enter on disabled rich text (#59320)
ellatrix Feb 24, 2024
78a4740
Fixed the font family modal to open in state when a font is already …
pbking Feb 27, 2024
914e64e
Font collection pagination: add min height to avoid infinite number (…
matiasbenedetto Feb 22, 2024
3d08702
Interactivity API: Fix `navigate()` issues related to initial state m…
DAreRodz Feb 26, 2024
fb06a14
Fix failing Dropdown Menu e2e tests (#59356)
Mamaduka Feb 26, 2024
41d6af5
Remove the tests that no longer test the code in Gutenberg but the co…
matiasbenedetto Feb 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unneeded pattern overrides translation strings (#59269)
Co-authored-by: kevin940726 <kevin940726@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>
  • Loading branch information
3 people authored and getdave committed Feb 27, 2024
commit 71746c4f9b782c6ca273376f33c62ace11666f48
6 changes: 3 additions & 3 deletions packages/patterns/src/components/partial-syncing-controls.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { PARTIAL_SYNCING_SUPPORTED_BLOCKS } from '../constants';

function PartialSyncingControls( { name, attributes, setAttributes } ) {
const syncedAttributes = PARTIAL_SYNCING_SUPPORTED_BLOCKS[ name ];
const attributeSources = Object.keys( syncedAttributes ).map(
const attributeSources = syncedAttributes.map(
( attributeName ) =>
attributes.metadata?.bindings?.[ attributeName ]?.source
);
Expand All @@ -36,7 +36,7 @@ function PartialSyncingControls( { name, attributes, setAttributes } ) {
};

if ( ! isChecked ) {
for ( const attributeName of Object.keys( syncedAttributes ) ) {
for ( const attributeName of syncedAttributes ) {
if (
updatedBindings[ attributeName ]?.source ===
'core/pattern-overrides'
Expand All @@ -56,7 +56,7 @@ function PartialSyncingControls( { name, attributes, setAttributes } ) {
return;
}

for ( const attributeName of Object.keys( syncedAttributes ) ) {
for ( const attributeName of syncedAttributes ) {
if ( ! updatedBindings[ attributeName ] ) {
updatedBindings[ attributeName ] = {
source: 'core/pattern-overrides',
Expand Down
23 changes: 4 additions & 19 deletions packages/patterns/src/constants.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
/**
* WordPress dependencies
*/
import { __ } from '@wordpress/i18n';

export const PATTERN_TYPES = {
theme: 'pattern',
user: 'wp_block',
Expand All @@ -22,18 +17,8 @@ export const PATTERN_SYNC_TYPES = {

// TODO: This should not be hardcoded. Maybe there should be a config and/or an UI.
export const PARTIAL_SYNCING_SUPPORTED_BLOCKS = {
'core/paragraph': { content: __( 'Content' ) },
'core/heading': { content: __( 'Content' ) },
'core/button': {
text: __( 'Text' ),
url: __( 'URL' ),
linkTarget: __( 'Link Target' ),
rel: __( 'Link Relationship' ),
},
'core/image': {
id: __( 'Image ID' ),
url: __( 'URL' ),
title: __( 'Title' ),
alt: __( 'Alt Text' ),
},
'core/paragraph': [ 'content' ],
'core/heading': [ 'content' ],
'core/button': [ 'text', 'url', 'linkTarget', 'rel' ],
'core/image': [ 'id', 'url', 'title', 'alt' ],
};