Skip to content

Allow saving and publishing posts #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nylen merged 22 commits into from
May 5, 2017
Merged

Allow saving and publishing posts #594

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
b576908
Add post object to editor state
nylen May 1, 2017
516a213
Add basic publish button component
nylen May 1, 2017
d2d6050
Do not use `wp_localize_script` for post content
nylen May 1, 2017
e4e8044
Implement saving/publishing posts
nylen May 1, 2017
7a994ea
Update page URL after creating a new post
nylen May 1, 2017
fe02d3f
Make eslint happy again
nylen May 1, 2017
77c37c9
Make the test suite happy again
nylen May 1, 2017
b9ac89d
Make message determination more readable
nylen May 2, 2017
ad29d20
Save drafts instead of publishing posts
nylen May 2, 2017
9954198
Move `savePost` to a new `actions.js` file
nylen May 2, 2017
8cce4eb
Rename `state.api` to `state.saving`
nylen May 2, 2017
12252a0
Change POST_UPDATE_REQUEST to REQUEST_POST_UPDATE
nylen May 4, 2017
53fb259
Parse the query string rather than using a regex replace
nylen May 4, 2017
a2fcfea
Store post edits in undoable state and full post object in another key
nylen May 4, 2017
5b2c081
Fix a typo in the `saving` reducer
nylen May 4, 2017
dbcb85b
Simplify assignment of `buttonEnabled` flag
nylen May 4, 2017
72e7aa8
Use ellipsis character instead of three dots
nylen May 4, 2017
7872b75
Clarify window.location splitting logic using array destructuring
nylen May 4, 2017
5106309
Add tests for `editor.edits` reducer
nylen May 5, 2017
0702d66
Add tests for `currentPost` reducer
nylen May 5, 2017
e938d3e
Add tests for `saving` reducer
nylen May 5, 2017
d83ea67
Update dirty state key
nylen May 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Parse the query string rather than using a regex replace 
#594 (comment)
  • Loading branch information
@nylen
nylen committed May 5, 2017
commit 53fb259257aeb790157af82f39172301ee6c5a99
14 changes: 8 additions & 6 deletions editor/actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
* External dependencies
*/
import { get } from 'lodash';
import { parse, stringify } from 'querystring';

export function savePost( dispatch, post ) {
const isNew = ! post.id;
Expand All @@ -17,12 +18,13 @@ export function savePost( dispatch, post ) {
isNew,
} );
if ( isNew && window.history.replaceState ) {
window.history.replaceState(
{},
'Post ' + newPost.id,
window.location.href.replace( /&post_id=[^&]*$/, '' )
+ '&post_id=' + newPost.id
);
const urlPieces = window.location.href.split( '?' );
const qs = parse( urlPieces[ 1 ] || '' );
const newUrl = urlPieces[ 0 ] + '?' + stringify( {
...qs,
Copy link
Member

@aduth aduth May 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: The object spread syntax creates another clone step; this is the equivalent of:

Object.assign( {}, qs, { post_id: newPost.id } );

Since we've created and have no plans to reuse the object outside the scope of the function, I think it'd be fine enough to mutate qs by assigning directly into it:

Object.assign( qs, { post_id: newPost.id } );

Copy link
Member Author

@nylen nylen May 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this, and I think the code clarity / elegance due to using the spread operator is worth the extra clone step. I don't think the performance is a concern here as this is not called very often and the browser's replaceState is going to be orders of magnitude more expensive than the assign.

post_id: newPost.id,
} );
window.history.replaceState( {}, 'Post ' + newPost.id, newUrl );
}
} ).fail( ( err ) => {
dispatch( {
Expand Down