Skip to content

HStack, VStack: Stop passing invalid props #59416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirka merged 5 commits into from
Feb 28, 2024
Merged

HStack, VStack: Stop passing invalid props #59416

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
65b9624
Add tests
mirka Feb 27, 2024
1f64ff6
HStack, VStack: Stop passing invalid props
mirka Feb 27, 2024
95edd27
useFlex: Fix return types
mirka Feb 27, 2024
4c079de
Add changelog
mirka Feb 27, 2024
ccc34bc
Merge branch 'trunk' into fix/h-stack-prop-error
mirka Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add tests
  • Loading branch information
@mirka
mirka committed Feb 27, 2024
commit 65b9624934e23aed8733375fc019574920d6d7b6
10 changes: 10 additions & 0 deletions packages/components/src/h-stack/test/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,14 @@ describe( 'props', () => {
);
expect( container ).toMatchSnapshot();
} );

test( 'should not pass through invalid props to the `as` component', () => {
const AsComponent = ( props: JSX.IntrinsicElements[ 'div' ] ) => {
return <div { ...props } />;
};

render( <HStack as={ AsComponent }>foobar</HStack> );

expect( console ).not.toHaveErrored();
} );
} );
10 changes: 10 additions & 0 deletions packages/components/src/v-stack/test/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,14 @@ describe( 'props', () => {
);
expect( container ).toMatchSnapshot();
} );

test( 'should not pass through invalid props to the `as` component', () => {
const AsComponent = ( props: JSX.IntrinsicElements[ 'div' ] ) => {
return <div { ...props } />;
};

render( <VStack as={ AsComponent }>foobar</VStack> );

expect( console ).not.toHaveErrored();
} );
} );