Skip to content

Allow uploading fonts from multiple font families at once using the Uploads tab #59425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matiasbenedetto wants to merge 1 commit into from
Closed

Allow uploading fonts from multiple font families at once using the Uploads tab #59425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Allow uploading fonts from multiple font families at once using the U… 
…ploads tab.
  • Loading branch information
@matiasbenedetto
matiasbenedetto committed Feb 28, 2024
commit a25150597d90724703af6e7c4a3bebd6631ba848
15 changes: 4 additions & 11 deletions packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,19 +143,12 @@ function UploadFonts() {
const handleInstall = async ( fontFaces ) => {
const fontFamilies = makeFamiliesFromFaces( fontFaces );

if ( fontFamilies.length > 1 ) {
setNotice( {
type: 'error',
message: __(
'Variants from only one font family can be uploaded at a time.'
),
} );
setIsUploading( false );
return;
}
const installPromises = fontFamilies.map( ( fontFamily ) =>
installFont( fontFamily )
);

try {
await installFont( fontFamilies[ 0 ] );
await Promise.all( installPromises );
setNotice( {
type: 'success',
message: __( 'Fonts were installed successfully.' ),
Expand Down