Add click outside toggling to block switcher menu. #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along with #582 this will cover #376. This adds the click outside higher order component to the block switcher menu. So that clicks into block content will close the menu while it is open. **Testing instructions:** Go to a heading or text block. Open the block switcher menu in the top left. Click on that blocks text content outside of the menu. Verify that the menu closes. Repeat this by clicking anywhere and verifying that the switcher closes. Verify that the switcher still works by clicking on it.
aduth
approved these changes
May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with #582 this will cover #376. This adds the click outside
higher order component to the block switcher menu. So that clicks into
block content will close the menu while it is open.
Testing instructions:
Go to a heading or text block. Open the block switcher menu in the top
left. Click on that blocks text content outside of the menu. Verify
that the menu closes. Repeat this by clicking anywhere and verifying
that the switcher closes. Verify that the switcher still works by
clicking on it.