Interactivity API: Prevent non-object state from being added#59886
Merged
Interactivity API: Prevent non-object state from being added#59886
Conversation
|
Size Change: +5 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
sirreal
requested review from
DAreRodz,
Mamaduka,
ajitbohra,
kevin940726,
luisherranz,
nerrad and
ntwb
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
sirreal
added
[Type] Bug
Member
Author
|
The status check is confused here, it says there's a failing label job, but that seems stake or wrong. I do need to add a changelog before this lands. |
DAreRodz
approved these changes
Mar 15, 2024
Contributor
DAreRodz
left a comment
DAreRodz
left a comment
There was a problem hiding this comment.
Fix looks good to me, 😄 although I would move the test to store.spec.ts and packages/e2e-tests/plugins/interactive-blocks/store/, as those are the test files we currently have for the store() function.
Could you update that before merging?
sirreal
force-pushed
the
fix/interactivity-initial-state-non-object
branch
from
5a5c346 to
922919e
Compare
Member
Author
|
I've updated the tests as requested and verified they fail if I revert the fix: |
cbravobernal
added a commit
that referenced
this pull request
Mar 15, 2024
cbravobernal
added a commit
that referenced
this pull request
Mar 15, 2024
* Add mode to directive processing * Add #59886 wp-develop fix * Add #6251 fix * Fix linter * Include #6261 wp-develop * Fix spacing Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org> Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
youknowriad
pushed a commit
that referenced
this pull request
Mar 18, 2024
Ensure that `state` is an object when creating a store for a given namespace. `store.state` is expected to be an object. There is code that prevents state from being updated if it is not an object, but it's possible to set the state to a non-object initially, which breaks subsequent updates. Co-authored-by: sirreal <jonsurrell@git.wordpress.org> Co-authored-by: DAreRodz <darerodz@git.wordpress.org>
Contributor
|
I just cherry-picked this PR to the update/packages-rc2-6.5 branch to get it included in the next release: 6421202 |
youknowriad
added
Backported to WP Core
getdave
pushed a commit
that referenced
this pull request
Mar 18, 2024
Ensure that `state` is an object when creating a store for a given namespace. `store.state` is expected to be an object. There is code that prevents state from being updated if it is not an object, but it's possible to set the state to a non-object initially, which breaks subsequent updates. Co-authored-by: sirreal <jonsurrell@git.wordpress.org> Co-authored-by: DAreRodz <darerodz@git.wordpress.org>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
…ss#59886) Ensure that `state` is an object when creating a store for a given namespace. `store.state` is expected to be an object. There is code that prevents state from being updated if it is not an object, but it's possible to set the state to a non-object initially, which breaks subsequent updates. Co-authored-by: sirreal <jonsurrell@git.wordpress.org> Co-authored-by: DAreRodz <darerodz@git.wordpress.org>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
* Add mode to directive processing * Add WordPress#59886 wp-develop fix * Add WordPress#6251 fix * Fix linter * Include WordPress#6261 wp-develop * Fix spacing Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org> Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Prevent interactivity store state from being set to non-object.
Why?
store.stateis expected to be an object. There is code that prevents state from being updated if it is not an object, but it's possible to set the state to a non-object initially, which breaks subsequent updates.See WordPress/wordpress-develop#6261 (comment) and this Core Trac comment for related details.
How?
isObjectchecks are applied when updating state, apply isObject to initial state as well, default to{}if non-object state was provided.Testing Instructions
This PR includes e2e tests. You can see a failing run before the fix was pushed here.