-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Editor: Add global styles data to editor settings #59929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3c2185d
Add global styles to editor settings
michalczaplinski ecb7b7e
Add comment
michalczaplinski 97aafab
Add __globalStyles to BLOCK_EDITOR_SETTINGS
michalczaplinski 172cc9a
Fix typo in editor.js
michalczaplinski 1094261
Remove unused code and update global styles
michalczaplinski e126a77
Update global styles key in useBlockEditorSettings
michalczaplinski 61bf5b1
Remove TODO comment
michalczaplinski 2183ab6
Fix default styles value in useStyles function
michalczaplinski 4a5b69a
Editor: Address feedback on addition of global styles to editor setti…
aaronrobertshaw 2e70b96
Only return merged global styles data
aaronrobertshaw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Add global styles to editor settings
- Loading branch information
commit 3c2185da8f667f3973627474032d1a65db669216
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /** | ||
| * WordPress dependencies | ||
| */ | ||
| import { useMemo } from '@wordpress/element'; | ||
| import { useSelect } from '@wordpress/data'; | ||
| import { store as coreStore } from '@wordpress/core-data'; | ||
|
|
||
| export function useStyles() { | ||
| const { styles, isReady } = useSelect( ( select ) => { | ||
| const { getEditedEntityRecord, hasFinishedResolution } = | ||
| select( coreStore ); | ||
| const _globalStylesId = | ||
| select( coreStore ).__experimentalGetCurrentGlobalStylesId(); | ||
|
||
| const record = _globalStylesId | ||
| ? getEditedEntityRecord( 'root', 'globalStyles', _globalStylesId ) | ||
| : undefined; | ||
|
|
||
| let hasResolved = false; | ||
| if ( | ||
| hasFinishedResolution( '__experimentalGetCurrentGlobalStylesId' ) | ||
| ) { | ||
| hasResolved = _globalStylesId | ||
| ? hasFinishedResolution( 'getEditedEntityRecord', [ | ||
| 'root', | ||
| 'globalStyles', | ||
| _globalStylesId, | ||
| ] ) | ||
| : true; | ||
| } | ||
|
|
||
| return { | ||
| isReady: hasResolved, | ||
| styles: record?.styles, | ||
| }; | ||
| }, [] ); | ||
|
|
||
| // Make sure to recompute the styles when hasResolved changes. | ||
| const config = useMemo( () => { | ||
ramonjd marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| return { | ||
| styles: styles ?? 'no styless', | ||
| isReady, | ||
| }; | ||
| }, [ isReady, styles ] ); | ||
|
|
||
| return config; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.