Skip to content

Fix self closing navigation overlay #60130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
getdave merged 1 commit into from
Mar 25, 2024
Merged

Fix self closing navigation overlay #60130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/block-library/src/navigation/view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,14 @@ const { state, actions } = store(
actions.openMenu( 'hover' );
},
closeMenuOnHover() {
actions.closeMenu( 'hover' );
const { type, overlayOpenedBy } = getContext();
if (
type === 'submenu' &&
// Only open on hover if the overlay is closed.
Copy link
Contributor

@scruffian scruffian Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Only open on hover if the overlay is closed.
// Only close on hover if the overlay is closed.

Copy link
Contributor

@getdave getdave Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in #60162

Object.values( overlayOpenedBy || {} ).filter( Boolean )
.length === 0
)
actions.closeMenu( 'hover' );
},
openMenuOnClick() {
const ctx = getContext();
Expand Down