Skip to content

Background image: add support for absolute theme path URLs #60578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ramonjd wants to merge 15 commits into from
Closed

Background image: add support for absolute theme path URLs #60578

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5c83713
Supporting background.backgroundImage.source === "theme" relative paths
ramonjd Apr 9, 2024
5b27773
This is an experimental commit to test out how to:
ramonjd Apr 9, 2024
6bf575a
Roll back API changes and insert into editor settings under `currentT…
ramonjd Apr 10, 2024
967bbac
If we pass a 'baseUrl' to the style engine, it will it append it to a…
ramonjd Apr 11, 2024
e65bf84
Rolls back f7bf075d4a0b143008f1809c8254ebab61492e00
ramonjd Apr 11, 2024
9e517d3
Removed useBlockProps and now editing style object directly
ramonjd Apr 11, 2024
bbddc18
Remove unused "parentDirectoryURI" prop in block editor settings
ramonjd Apr 15, 2024
1827703
Yes, spacing.
ramonjd Apr 15, 2024
39b8783
Unit test no styles
ramonjd Apr 15, 2024
8b27b57
Getting URI from themes API response
ramonjd Apr 18, 2024
f8cda05
Switching to experimental
ramonjd Apr 18, 2024
df2ffb1
Testing get_theme_file_uri on the backend and duping the background i…
ramonjd Apr 29, 2024
eca8d3c
Just a commit to explore adding a private selector to mimic get_theme…
ramonjd Apr 30, 2024
7e9e4c5
whoops
ramonjd Apr 30, 2024
1aa8f6a
Resolving urls in theme.json
ramonjd May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Yes, spacing.
  • Loading branch information
@ramonjd
ramonjd committed May 1, 2024
commit 1827703193691155886b251270ef1936c8abc741
2 changes: 1 addition & 1 deletion lib/block-editor-settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ function gutenberg_get_block_editor_settings( $settings ) {
$current_theme = wp_get_theme();
Copy link
Member Author

@ramonjd ramonjd Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using wp_get_theme to get full WP_Theme object in case folks want to use other helpful methods.

$settings['currentTheme'] = array(
// Directory of the current theme. Will be the child theme directory if a child theme is active.
'directoryURI' => $current_theme->get_stylesheet_directory_uri(),
'directoryURI' => $current_theme->get_stylesheet_directory_uri(),
// `__unstableIsBlockBasedTheme` could also be relocated here, e.g., 'isBlockTheme' => $current_theme->is_block_theme().
);

Expand Down